Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 3 | Practice-tdd by RomanSanaye · Pull Request #1167 · CodeYourFuture/Module-Structuring-and-Testing-Data

RomanSanaye · 2026-03-04T17:36:00Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Implemented the following functions:

count
getOrdinalNumber
repeatStr

Each function handles the required cases and passes all Jest test cases, including edge cases (positive, zero, and negative values where applicable).

All tests are passing successfully.

…; pass all test cases

cjyuan

I noticed some minor format inconsistency.

Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode, as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?

If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.

If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:

Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".
Edit settings.json and set Prettier as the default formatter for JS.
See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

cjyuan · 2026-03-13T07:06:16Z

Sprint-3/2-practice-tdd/count.js

+    if (numberOfChar === 0) {
+     return `0 ${findCharacter} found.`
+    }


The function is expected to return an integer number. Returning a string would make the function difficult to use because the caller would need to check the data type of the return value.

Hello @cjyuan ,
I have updated the function so it now always returns an integer. Returning 0 instead of a string ensures the function is easier to use and matches the expected return type.

cjyuan · 2026-03-13T07:08:06Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+  expect(getOrdinalNumber(33)).toEqual("33rd");
+  expect(getOrdinalNumber(333)).toEqual("333rd");
+});
+test("should append 'th' for numbers ending with 4 and more than 4", () => {


... ending with 4-9, 0 might be more concise.

I have updated the ordinal number test descriptions to group numbers ending in 4-9 and 0, making the tests more concise while still covering all cases.

cjyuan · 2026-03-13T07:09:21Z

Sprint-3/2-practice-tdd/repeat-str.test.js

 // When the repeatStr function is called with these inputs,
 // Then it should return the original `str` without repetition.
-
+test("should print the original string", () => {


"print" may suggest the function should output the string.

I have updated the test description to say “return” instead of “print” to accurately reflect that the function returns a string rather than printing it.

cjyuan · 2026-03-13T07:10:48Z

Sprint-3/2-practice-tdd/repeat-str.test.js

 // When the repeatStr function is called with these inputs,
 // Then it should return an empty string.
-
+test("should return an empty string", () => {


You could probably make this description more informative by including the when ... part.

I have revised the test descriptions to include the input condition (when …) so they clearly state under what circumstances the function should return the expected result.

cjyuan · 2026-03-19T12:36:08Z

There is no new commits on this branch, and the comments are not yet addressed.

If you have responded to the comments, you may want to check if the responses are in "Pending" state. Other users cannot see the pending comments.

cjyuan · 2026-03-19T14:00:57Z

Sprint-3/2-practice-tdd/count.js

 function countChar(stringOfCharacters, findCharacter) {
-  return 5
+  if (!stringOfCharacters || !findCharacter) {
+    return 0;
+  }
+  let numberOfChar = 0;
+  for (let wantedChar of stringOfCharacters) {
+    if (wantedChar === findCharacter) {
+      numberOfChar++;
+    }
+    if (numberOfChar === 0) {
+      return 0;
+    }
+  }
+  return numberOfChar;
 }


This function has a bug; it does not always return the correct count.

If you cannot figure out the bug, try testing a few more samples in count.test.js.

RomanSanaye · 2026-03-19T15:49:30Z

Hi @cjyuan , thanks for your feedback.

I have addressed all the comments:

Updated the function to always return a number instead of a string
Fixed the bug in countChar by removing the early return inside the loop so it now correctly counts all characters
Improved test descriptions to use “return” instead of “print”
Made test descriptions more informative by including the “when…” part
Simplified ordinal number tests by grouping cases (e.g. numbers ending in 4–9 and 0)

I have also added the “Needs Review” label.

Please let me know if anything else is required.

cjyuan · 2026-03-19T19:04:25Z

Changes look good, and thanks for the clear explanation in the responses. Well done.

Implement functions to repeat strings, get ordinal numbers, and count…

639af4c

…; pass all test cases

RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026

RomanSanaye mentioned this pull request Mar 6, 2026

ITP-Jan | Structuring and testing data | Roman Sanaye RomanSanaye/My-Coursework-Planner#85

Open

WIP: updates to repeat-str.test.js

e73df46

cjyuan reviewed Mar 13, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 13, 2026

RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

practice-tdd files were updated

da793bd

RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

cjyuan reviewed Mar 19, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

bug fixed from count.js

48f34dd

RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 19, 2026

Uh oh!

Conversation

RomanSanaye commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Mar 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RomanSanaye commented Mar 19, 2026

Uh oh!

cjyuan commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RomanSanaye commented Mar 4, 2026 •

edited

Loading